Skip to content

Commit 2ce8908

Browse files
committed
build: do not match v8_libplatform_headers when scraping sources
Otherwise the target contains undefined symbols because there are only header files in the list. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 5029693 commit 2ce8908

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1782,7 +1782,7 @@
17821782
'v8_libbase',
17831783
],
17841784
'sources': [
1785-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?sources = ")',
1785+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?sources = ")',
17861786
],
17871787
'conditions': [
17881788
['component=="shared_library"', {
@@ -1793,10 +1793,10 @@
17931793
}],
17941794
['v8_use_perfetto==1', {
17951795
'sources!': [
1796-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\-= ")',
1796+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\-= ")',
17971797
],
17981798
'sources': [
1799-
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_libplatform.*?v8_use_perfetto.*?sources \\+= ")',
1799+
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "v8_component.\\"v8_libplatform\\".*?v8_use_perfetto.*?sources \\+= ")',
18001800
],
18011801
'conditions': [
18021802
['node_shared_perfetto=="false"', {

0 commit comments

Comments
 (0)