From 2cd68be69d7a60e8b419085e42a0cf7bfcd6ea2f Mon Sep 17 00:00:00 2001 From: Refael Ackermann Date: Thu, 18 Oct 2018 11:00:11 -0400 Subject: [PATCH] build: spawn `make test-ci` with `-j1` All the sub targets have internal parallelism, so no performance loss. Also `make` doesn't to a good enough job of combining the output streams, or eliminate races. PR-URL: https://github.com/nodejs/node/pull/23733 Fixes: https://github.com/nodejs/node/issues/22006 Reviewed-By: Richard Lau Reviewed-By: Joyee Cheung Reviewed-By: Matheus Marchini --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 05d3056f27973e..a98772faea6dca 100644 --- a/Makefile +++ b/Makefile @@ -480,8 +480,11 @@ build-ci: # of tests. See `test-ci-native` and `test-ci-js`. # - node-test-commit-linux-coverage: where the build and the tests need # to be instrumented, see `coverage`. +# +# Using -j1 as the sub target in `test-ci` already have internal parallelism. +# Refs: https://github.com/nodejs/node/pull/23733 run-ci: build-ci - $(MAKE) test-ci + $(MAKE) test-ci -j1 test-release: test-build $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER)