src: don't run tasks on isolate termination

santigimeno · danielleadams · commit 2c6a4fd6fa21 · 2023-01-03T08:38:51.000-05:00
Fixes: #45419 PR-URL: #45444 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -406,7 +406,7 @@ int NodePlatform::NumberOfWorkerThreads() {
 }
 
 void PerIsolatePlatformData::RunForegroundTask(std::unique_ptr<Task> task) {
-  if (isolate_->IsExecutionTerminating()) return task->Run();
+  if (isolate_->IsExecutionTerminating()) return;
   DebugSealHandleScope scope(isolate_);
   Environment* env = Environment::GetCurrent(isolate_);
   if (env != nullptr) {

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ int NodePlatform::NumberOfWorkerThreads() {`
`406`	`406`	`}`
`407`	`407`
`408`	`408`	`void PerIsolatePlatformData::RunForegroundTask(std::unique_ptr<Task> task) {`
`409`		`- if (isolate_->IsExecutionTerminating()) return task->Run();`
	`409`	`+ if (isolate_->IsExecutionTerminating()) return;`
`410`	`410`	`DebugSealHandleScope scope(isolate_);`
`411`	`411`	`Environment* env = Environment::GetCurrent(isolate_);`
`412`	`412`	`if (env != nullptr) {`