From 2c5b27a247b5277955b7e5d1d883511f16dd5d99 Mon Sep 17 00:00:00 2001 From: marzelin Date: Wed, 12 Oct 2016 21:57:04 +0200 Subject: [PATCH] doc: improved example for http.get PR-URL: https://github.com/nodejs/node/pull/9065 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca --- doc/api/http.md | 45 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/doc/api/http.md b/doc/api/http.md index 608760f66534d1..ecdde9b5d0f82e 100644 --- a/doc/api/http.md +++ b/doc/api/http.md @@ -1448,16 +1448,47 @@ added: v0.3.6 * Returns: {http.ClientRequest} Since most requests are GET requests without bodies, Node.js provides this -convenience method. The only difference between this method and [`http.request()`][] -is that it sets the method to GET and calls `req.end()` automatically. +convenience method. The only difference between this method and +[`http.request()`][] is that it sets the method to GET and calls `req.end()` +automatically. Note that response data must be consumed in the callback +for reasons stated in [`http.ClientRequest`][] section. -Example: +The `callback` is invoked with a single argument that is an instance of +[`http.IncomingMessage`][] + +JSON Fetching Example: ```js -http.get('http://www.google.com/index.html', (res) => { - console.log(`Got response: ${res.statusCode}`); - // consume response body - res.resume(); +http.get('http://nodejs.org/dist/index.json', (res) => { + const statusCode = res.statusCode; + const contentType = res.headers['content-type']; + + let error; + if (statusCode !== 200) { + error = new Error(`Request Failed.\n` + + `Status Code: ${statusCode}`); + } else if (!/^application\/json/.test(contentType)) { + error = new Error(`Invalid content-type.\n` + + `Expected application/json but received ${contentType}`); + } + if (error) { + console.log(error.message); + // consume response data to free up memory + res.resume(); + return; + } + + res.setEncoding('utf8'); + let rawData = ''; + res.on('data', (chunk) => rawData += chunk); + res.on('end', () => { + try { + let parsedData = JSON.parse(rawData); + console.log(parsedData); + } catch (e) { + console.log(e.message); + } + }); }).on('error', (e) => { console.log(`Got error: ${e.message}`); });