From 2a5d85c07c8a78b6ff6f6f8dc2924f5d6ee9bee6 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Mon, 7 Jan 2019 22:24:22 -0800 Subject: [PATCH] test: remove test/pummel/test-http-client-reconnect-bug.js test-http-client-reconnect-bug depends on `http.createClient()` which was removed in Node.js 7.0.0. The test was added way back in commit 30b0522157069360615402651d6b98c9397dfc19 for a bug fixed in Node.js 0.1.27 in early 2010. We've apparently been fine with it failing since at least Node.js 7.0.0 which at this time is more than 2 years ago. Remove this test. PR-URL: https://github.com/nodejs/node/pull/25387 Reviewed-By: Daniel Bevenius Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater --- test/pummel/test-http-client-reconnect-bug.js | 48 ------------------- 1 file changed, 48 deletions(-) delete mode 100644 test/pummel/test-http-client-reconnect-bug.js diff --git a/test/pummel/test-http-client-reconnect-bug.js b/test/pummel/test-http-client-reconnect-bug.js deleted file mode 100644 index d3e540166c27a7..00000000000000 --- a/test/pummel/test-http-client-reconnect-bug.js +++ /dev/null @@ -1,48 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -'use strict'; -const common = require('../common'); -const net = require('net'); -const http = require('http'); - -const server = net.createServer(function(socket) { - socket.end(); -}); - -server.on('listening', common.mustCall(function() { - const client = http.createClient(common.PORT); - - client.on('error', common.mustCall()); - client.on('end', common.mustCall()); - - const request = client.request('GET', '/', { 'host': 'localhost' }); - request.end(); - request.on('response', function(response) { - console.log(`STATUS: ${response.statusCode}`); - }); -})); - -server.listen(common.PORT); - -setTimeout(function() { - server.close(); -}, 500);