Skip to content

Commit 27efa05

Browse files
jasnelljuanarbol
authored andcommitted
src: improve token return value check
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 6bed3e3 commit 27efa05

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

src/quic/tokens.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,9 @@ ngtcp2_vec GenerateRetryToken(uint8_t* buffer,
155155
odcid,
156156
uv_hrtime());
157157
DCHECK_GE(ret, 0);
158-
DCHECK_LE(ret, RetryToken::kRetryTokenLen);
159158
DCHECK_EQ(buffer[0], RetryToken::kTokenMagic);
160159
// This shouldn't be possible but we handle it anyway just to be safe.
161-
if (ret == 0) return {nullptr, 0};
160+
if (ret <= 0) return {nullptr, 0};
162161
return {buffer, static_cast<size_t>(ret)};
163162
}
164163

@@ -174,10 +173,9 @@ ngtcp2_vec GenerateRegularToken(uint8_t* buffer,
174173
address.length(),
175174
uv_hrtime());
176175
DCHECK_GE(ret, 0);
177-
DCHECK_LE(ret, RegularToken::kRegularTokenLen);
178176
DCHECK_EQ(buffer[0], RegularToken::kTokenMagic);
179177
// This shouldn't be possible but we handle it anyway just to be safe.
180-
if (ret == 0) return {nullptr, 0};
178+
if (ret <= 0) return {nullptr, 0};
181179
return {buffer, static_cast<size_t>(ret)};
182180
}
183181
} // namespace

0 commit comments

Comments
 (0)