Skip to content

Commit 25751be

Browse files
committed
node: deprecate process.EventEmitter
The comment stating it was deprecated was added in 2011 via 4ef8f06. It is time to actually deprecate it. PR-URL: #5049 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
1 parent 7406cd3 commit 25751be

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/node.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,17 @@
2020
});
2121
EventEmitter.call(process);
2222

23-
process.EventEmitter = EventEmitter; // process.EventEmitter is deprecated
23+
let eeWarned = false;
24+
Object.defineProperty(process, 'EventEmitter', {
25+
get() {
26+
const internalUtil = NativeModule.require('internal/util');
27+
eeWarned = internalUtil.printDeprecationMessage(
28+
`process.EventEmitter is deprecated. Use require('events') instead.`,
29+
eeWarned
30+
);
31+
return EventEmitter;
32+
}
33+
});
2434

2535
startup.setupProcessObject();
2636

0 commit comments

Comments
 (0)