test: fix pummel/test-net-connect-memleak

Trott · targos · commit 24f649c8cf69 · 2018-07-09T22:40:40.000+02:00
A loop that generates a long array is resulting in a RangeError. Moving to Array.prototype.fill() along with the ** operator instead of using a loop fixes the issue. PR-URL: #21658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
diff --git a/test/pummel/test-net-connect-memleak.js b/test/pummel/test-net-connect-memleak.js
@@ -37,8 +37,7 @@ let before = 0;
 {
   // 2**26 == 64M entries
   global.gc();
-  let junk = [0];
-  for (let i = 0; i < 26; ++i) junk = junk.concat(junk);
+  const junk = new Array(2 ** 26).fill(0);
   before = process.memoryUsage().rss;
 
   net.createConnection(common.PORT, '127.0.0.1', function() {

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ let before = 0;`
`37`	`37`	`{`
`38`	`38`	`// 2**26 == 64M entries`
`39`	`39`	`global.gc();`
`40`		`- let junk = [0];`
`41`		`- for (let i = 0; i < 26; ++i) junk = junk.concat(junk);`
	`40`	`+ const junk = new Array(2 ** 26).fill(0);`
`42`	`41`	`before = process.memoryUsage().rss;`
`43`	`42`
`44`	`43`	`net.createConnection(common.PORT, '127.0.0.1', function() {`