Skip to content

Commit 24205e8

Browse files
committed
apply suggestions from @redyetidev code review
1 parent f67262f commit 24205e8

File tree

1 file changed

+20
-23
lines changed

1 file changed

+20
-23
lines changed

doc/api/readline.md

Lines changed: 20 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -713,11 +713,9 @@ const rl = createInterface({
713713
```
714714

715715
```cjs
716-
const readlinePromises = require('node:readline/promises');
717-
const rl = readlinePromises.createInterface({
718-
input: process.stdin,
719-
output: process.stdout,
720-
});
716+
const { createInterface } = require('node:readline/promises');
717+
const { stdin: input, stdout: output } = require('node:process');
718+
const rl = createInterface({ input, output });
721719
```
722720

723721
Once the `readlinePromises.Interface` instance is created, the most common case
@@ -979,11 +977,9 @@ const rl = createInterface({
979977
```
980978

981979
```cjs
982-
const readline = require('node:readline');
983-
const rl = readline.createInterface({
984-
input: process.stdin,
985-
output: process.stdout,
986-
});
980+
const { createInterface } = require('node:readline');
981+
const { stdin: input, stdout: output } = require('node:process');
982+
const rl = createInterface({ input, output });
987983
```
988984

989985
Once the `readline.Interface` instance is created, the most common case is to
@@ -1144,10 +1140,11 @@ rl.on('line', (line) => {
11441140
```
11451141

11461142
```cjs
1147-
const readline = require('node:readline');
1148-
const rl = readline.createInterface({
1149-
input: process.stdin,
1150-
output: process.stdout,
1143+
const { createInterface } = require('node:readline');
1144+
const { exit, stdin, stdout } = require('node:process');
1145+
const rl = createInterface({
1146+
input: stdin,
1147+
output: stdout,
11511148
prompt: 'OHAI> ',
11521149
});
11531150

@@ -1165,7 +1162,7 @@ rl.on('line', (line) => {
11651162
rl.prompt();
11661163
}).on('close', () => {
11671164
console.log('Have a great day!');
1168-
process.exit(0);
1165+
exit(0);
11691166
});
11701167
```
11711168

@@ -1199,13 +1196,13 @@ processLineByLine();
11991196
```
12001197

12011198
```cjs
1202-
const fs = require('node:fs');
1203-
const readline = require('node:readline');
1199+
const { createReadStream } = require('node:fs');
1200+
const { createInterface } = require('node:readline');
12041201

12051202
async function processLineByLine() {
1206-
const fileStream = fs.createReadStream('input.txt');
1203+
const fileStream = createReadStream('input.txt');
12071204

1208-
const rl = readline.createInterface({
1205+
const rl = createInterface({
12091206
input: fileStream,
12101207
crlfDelay: Infinity,
12111208
});
@@ -1238,11 +1235,11 @@ rl.on('line', (line) => {
12381235
```
12391236

12401237
```cjs
1241-
const fs = require('node:fs');
1242-
const readline = require('node:readline');
1238+
const { createReadStream } = require('node:fs');
1239+
const { createInterface } = require('node:readline');
12431240

1244-
const rl = readline.createInterface({
1245-
input: fs.createReadStream('sample.txt'),
1241+
const rl = createInterface({
1242+
input: createReadStream('sample.txt'),
12461243
crlfDelay: Infinity,
12471244
});
12481245

0 commit comments

Comments
 (0)