diff --git a/lib/internal/readline/interface.js b/lib/internal/readline/interface.js index 5de6a8fe03da13..dacddaa39d65b8 100644 --- a/lib/internal/readline/interface.js +++ b/lib/internal/readline/interface.js @@ -45,6 +45,7 @@ const { const { validateAbortSignal, validateArray, + validateNumber, validateString, validateUint32, } = require('internal/validators'); @@ -199,13 +200,7 @@ function InterfaceConstructor(input, output, completer, terminal) { historySize = kHistorySize; } - if ( - typeof historySize !== 'number' || - NumberIsNaN(historySize) || - historySize < 0 - ) { - throw new ERR_INVALID_ARG_VALUE.RangeError('historySize', historySize); - } + validateNumber(historySize, 'historySize', 0); // Backwards compat; check the isTTY prop of the output stream // when `terminal` was not specified diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js index b5a3b0499fcdbd..707c651a244d04 100644 --- a/test/parallel/test-readline-interface.js +++ b/test/parallel/test-readline-interface.js @@ -126,7 +126,7 @@ function assertCursorRowsAndCols(rli, rows, cols) { }); // Constructor throws if historySize is not a positive number - ['not a number', -1, NaN, {}, true, Symbol(), null].forEach((historySize) => { + [-1, NaN].forEach((historySize) => { assert.throws(() => { readline.createInterface({ input, @@ -134,7 +134,20 @@ function assertCursorRowsAndCols(rli, rows, cols) { }); }, { name: 'RangeError', - code: 'ERR_INVALID_ARG_VALUE' + code: 'ERR_OUT_OF_RANGE' + }); + }); + + // Constructor throws if type of historySize is not a number + ['not a number', {}, true, Symbol(), null].forEach((historySize) => { + assert.throws(() => { + readline.createInterface({ + input, + historySize, + }); + }, { + name: 'TypeError', + code: 'ERR_INVALID_ARG_TYPE' }); }); diff --git a/test/parallel/test-readline-promises-interface.js b/test/parallel/test-readline-promises-interface.js index 2a211025cdb27b..99e02462312b9a 100644 --- a/test/parallel/test-readline-promises-interface.js +++ b/test/parallel/test-readline-promises-interface.js @@ -103,7 +103,7 @@ function assertCursorRowsAndCols(rli, rows, cols) { }); // Constructor throws if historySize is not a positive number - ['not a number', -1, NaN, {}, true, Symbol(), null].forEach((historySize) => { + [-1, NaN].forEach((historySize) => { assert.throws(() => { readline.createInterface({ input, @@ -111,7 +111,20 @@ function assertCursorRowsAndCols(rli, rows, cols) { }); }, { name: 'RangeError', - code: 'ERR_INVALID_ARG_VALUE' + code: 'ERR_OUT_OF_RANGE' + }); + }); + + // Constructor throws if type of historySize is not a number + ['not a number', {}, true, Symbol(), null].forEach((historySize) => { + assert.throws(() => { + readline.createInterface({ + input, + historySize, + }); + }, { + name: 'TypeError', + code: 'ERR_INVALID_ARG_TYPE' }); });