Skip to content

Commit 234a505

Browse files
codebyteremarco-ippolito
authored andcommitted
src: allow embedder customization of OOMErrorHandler
PR-URL: #57325 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
1 parent c0252cd commit 234a505

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/api/environment.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,10 @@ void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s) {
230230
auto* fatal_error_cb = s.fatal_error_callback ?
231231
s.fatal_error_callback : OnFatalError;
232232
isolate->SetFatalErrorHandler(fatal_error_cb);
233-
isolate->SetOOMErrorHandler(OOMErrorHandler);
233+
234+
auto* oom_error_cb =
235+
s.oom_error_callback ? s.oom_error_callback : OOMErrorHandler;
236+
isolate->SetOOMErrorHandler(oom_error_cb);
234237

235238
if ((s.flags & SHOULD_NOT_SET_PREPARE_STACK_TRACE_CALLBACK) == 0) {
236239
auto* prepare_stack_trace_cb = s.prepare_stack_trace_callback ?

src/node.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -483,6 +483,7 @@ struct IsolateSettings {
483483
v8::Isolate::AbortOnUncaughtExceptionCallback
484484
should_abort_on_uncaught_exception_callback = nullptr;
485485
v8::FatalErrorCallback fatal_error_callback = nullptr;
486+
v8::OOMErrorCallback oom_error_callback = nullptr;
486487
v8::PrepareStackTraceCallback prepare_stack_trace_callback = nullptr;
487488

488489
// Miscellaneous callbacks

0 commit comments

Comments
 (0)