Skip to content

Commit 228e703

Browse files
richardlaunodejs-github-bot
authored andcommitted
deps: workaround debug link error on Windows
PR-URL: #38807 Refs: #38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>
1 parent 9f0bc60 commit 228e703

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.10',
39+
'v8_embedder_string': '-node.11',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/fixed-array.h

+2
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,9 @@ class FixedArray
138138
inline void set(int index, Smi value);
139139
#else
140140
inline void set(int index, Smi value) {
141+
#if !defined(_WIN32)
141142
DCHECK_NE(map(), GetReadOnlyRoots().fixed_cow_array_map());
143+
#endif
142144
DCHECK_LT(static_cast<unsigned>(index), static_cast<unsigned>(length()));
143145
DCHECK(Object(value).IsSmi());
144146
int offset = OffsetOfElementAt(index);

0 commit comments

Comments
 (0)