Skip to content

Commit 21ac6c3

Browse files
GeoffreyBoothmcollinabnoordhuis
committed
Apply suggestions from code review
Co-authored-by: Matteo Collina <matteo.collina@gmail.com> Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 02845dd commit 21ac6c3

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

doc/api/cli.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@ Define which module system, `module` or `commonjs`, to use for the following:
723723

724724
In other words, `--experimental-type=module` flips all the places where Node.js
725725
currently defaults to CommonJS to instead default to ECMAScript modules, with
726-
the exception of packages inside `node_modules`.
726+
the exception of packages inside `node_modules`, for backward compatibility reasons.
727727

728728
Under `--experimental-type=module` and `--experimental-wasm-modules`, files with
729729
no extension will be treated as WebAssembly if they begin with the WebAssembly

lib/internal/modules/esm/formats.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function getFormatOfExtensionlessFile(url) {
5656
return 'wasm';
5757
}
5858
} finally {
59-
if (fd) { closeSync(fd); }
59+
if (fd !== undefined) { closeSync(fd); }
6060
}
6161

6262
return 'module';

0 commit comments

Comments
 (0)