Skip to content

Commit 20483aa

Browse files
richardlauruyadorno
authored andcommitted
crypto: fix RSA_PKCS1_PADDING error message
The ability to revert the fix for CVE-2023-46809 was only added to Node.js 18.x, 20.x and 21.x as, per policy, security reverts are only added to the existing supported release lines at the time of the fix. The error message thrown when `RSA_PKCS1_PADDING` is used on `main` and subsequent major versions (i.e. Node.js 22 and 23) when OpenSSL does not support implicit rejections should not have suggested that it is possible to revert the fix. PR-URL: #55629 Fixes: #55628 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent c91155f commit 20483aa

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/crypto/crypto_cipher.cc

+1-2
Original file line numberDiff line numberDiff line change
@@ -1093,8 +1093,7 @@ void PublicKeyCipher::Cipher(const FunctionCallbackInfo<Value>& args) {
10931093
if (rsa_pkcs1_implicit_rejection <= 0) {
10941094
return THROW_ERR_INVALID_ARG_VALUE(
10951095
env,
1096-
"RSA_PKCS1_PADDING is no longer supported for private decryption,"
1097-
" this can be reverted with --security-revert=CVE-2024-PEND");
1096+
"RSA_PKCS1_PADDING is no longer supported for private decryption");
10981097
}
10991098
}
11001099

0 commit comments

Comments
 (0)