Skip to content

Commit 200dadb

Browse files
richardlaumarco-ippolito
authored andcommitted
deps: V8: cherry-pick f8d5e576b814
Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent e2ae436 commit 200dadb

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.20',
40+
'v8_embedder_string': '-node.21',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/BUILD.gn

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1585,6 +1585,10 @@ config("toolchain") {
15851585
# of `this` in capture-by-value lambdas and preventing a build roll which
15861586
# enables C++20 (see https://crbug.com/1374227).
15871587
"-Wno-deprecated",
1588+
1589+
# Fix build with older versions of GCC
1590+
# Ported from v8 bazel: https://crrev.com/c/3368869
1591+
"-Wno-stringop-overflow",
15881592
]
15891593
}
15901594

0 commit comments

Comments
 (0)