Skip to content

Commit 1efd74b

Browse files
joyeecheungtargos
authored andcommitted
tools: fix release URL computation in update-root-certs.mjs
Previously this would compute the release tag to be something like FIREFOX_134_0.2_RELEASE which would not lead to a valid URL, failing to pull the latest NSS updates from the Firefox release. It should replace all the dots with underscores to compute something like FIREFOX_134_0_2_RELEASE instead. PR-URL: #56843 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
1 parent dfdaa92 commit 1efd74b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/dep_updaters/update-root-certs.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const getFirefoxRelease = async (version) => {
6565

6666
const getNSSVersion = async (release) => {
6767
const latestFirefox = release.version;
68-
const firefoxTag = `FIREFOX_${latestFirefox.replace('.', '_')}_RELEASE`;
68+
const firefoxTag = `FIREFOX_${latestFirefox.replaceAll('.', '_')}_RELEASE`;
6969
const tagInfoURL = `https://hg.mozilla.org/releases/mozilla-release/raw-file/${firefoxTag}/security/nss/TAG-INFO`;
7070
if (values.verbose) {
7171
console.log(`Fetching NSS tag from ${tagInfoURL}.`);

0 commit comments

Comments
 (0)