Skip to content

Commit

Permalink
doc: remove "multiple variants" from BUILDING.md
Browse files Browse the repository at this point in the history
The statement that tests for tier 1 platforms are run on multiple
variants is not true. We usually only run on one variant of macOS.
Remove "multiple", which simplifies and clarifies the statements anyway.

PR-URL: #30366
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Trott authored and MylesBorins committed Nov 17, 2019
1 parent 2d16a74 commit 1e26720
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ There are three support tiers:

* **Tier 1**: These platforms represent the majority of Node.js users. The
Node.js Build Working Group maintains infrastructure for full test coverage.
All commits to the Node.js repository are tested on multiple variants of these
platforms. Test failures on tier 1 platforms will block releases.
All commits to the Node.js repository are tested on these platforms. Test
failures on tier 1 platforms will block releases.
* **Tier 2**: These platforms represent smaller segments of the Node.js user
base. The Node.js Build Working Group maintains infrastructure for full test
coverage. All commits to the Node.js repository are tested on multiple
variants of these platforms where practical. Test failures on tier 2 platforms
will block releases. Delays in release of binaries for these platforms are
acceptable where necessary due to infrastructure concerns.
coverage. All commits to the Node.js repository are tested on these platforms.
Test failures on tier 2 platforms will block releases. Delays in release of
binaries for these platforms are acceptable where necessary due to
infrastructure concerns.
* **Experimental**: May not compile or test suite may not pass. The core team
does not create releases for these platforms. Test failures on experimental
platforms do not block releases. Contributions to improve support for these
Expand Down

0 comments on commit 1e26720

Please sign in to comment.