Skip to content

Commit 1e199ce

Browse files
Trotttargos
authored andcommitted
test: move test-http-max-http-headers to parallel
test-http-max-http-headers seems to run fine in parallel, even with `tools/test.py -j 96 --repeat 192 test/parallel/test-http-max-http-headers.js`. The same applies to `test-set-http-max-http-headers.js` which (as written) depends on `test-http-max-http-headers.js` being in the same directory. So that is being moved too. PR-URL: #30712 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 1918b4e commit 1e199ce

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

test/sequential/test-set-http-max-http-headers.js test/parallel/test-set-http-max-http-headers.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ test(function(cb) {
3737
NODE_DEBUG: 'http'
3838
});
3939

40-
// Validate that the test fails if the max header size is too small.
41-
// Validate that the test now passes if the same limit becomes large enough.
40+
// Validate that the test now passes if the same limit is large enough.
4241
const args = ['--expose-internals',
4342
'--max-http-header-size=1024',
4443
testName,
@@ -76,8 +75,7 @@ if (!process.config.variables.node_without_node_options) {
7675
});
7776

7877
test(function(cb) {
79-
// Validate that the test now passes if the same limit
80-
// becomes large enough.
78+
// Validate that the test now passes if the same limit is large enough.
8179
const args = ['--expose-internals', testName, '1024'];
8280
const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });
8381

0 commit comments

Comments
 (0)