stream: rename unknown primordial

The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612
nodejs · Oct 27, 2021 · 1e1822b · 1e1822b
1 parent 6df7070
commit 1e1822b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -7,7 +7,7 @@ const {
   ArrayBufferPrototypeSlice,
   ArrayPrototypePush,
   ArrayPrototypeShift,
-  DataViewCtor,
+  DataView,
   FunctionPrototypeBind,
   FunctionPrototypeCall,
   MathMin,
@@ -2100,7 +2100,7 @@ function readableByteStreamControllerPullInto(
     pendingPullIntos,
   } = controller[kState];
   let elementSize = 1;
-  let ctor = DataViewCtor;
+  let ctor = DataView;
   if (isArrayBufferView(view) && !isDataView(view)) {
     elementSize = view.constructor.BYTES_PER_ELEMENT;
     ctor = view.constructor;

diff --git a/test/parallel/test-whatwg-readablestream.js b/test/parallel/test-whatwg-readablestream.js
@@ -1570,3 +1570,18 @@ class Source {
     isDisturbed(stream, true);
   })().then(common.mustCall());
 }
+
+{
+  const stream = new ReadableStream({
+    type: 'bytes',
+    start(controller) {
+      controller.close();
+    }
+  });
+
+  const buffer = new ArrayBuffer(1024);
+  const reader = stream.getReader({ mode: 'byob' });
+
+  reader.read(new DataView(buffer))
+    .then(common.mustCall());
+}