lib: add unsubscribe method to non-active DC channels

PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
nodejs · Oct 23, 2021 · 1ddbae2 · 1ddbae2
1 parent aa61551
commit 1ddbae2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/doc/api/diagnostics_channel.md b/doc/api/diagnostics_channel.md
@@ -267,7 +267,7 @@ added:
 changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/40433
-    description: Added return value.
+    description: Added return value. Added to channels without subscribers.
 -->
 
 * `onMessage` {Function} The previous subscribed handler to remove

diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -81,6 +81,10 @@ class Channel {
     this.subscribe(subscription);
   }
 
+  unsubscribe() {
+    return false;
+  }
+
   get hasSubscribers() {
     return false;
   }