-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: enhance fs-watch-recursive test
This patch - issues a TAP plugin parsable message on non darwin/windows boxes - uses `const` wherever applicable - moves the test to parallel PR-URL: #2599 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
1 parent
5ed30da
commit 1c8a7c6
Showing
2 changed files
with
43 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
if (!(process.platform === 'darwin' || common.isWindows)) { | ||
console.log('1..0 # Skipped: recursive option is darwin/windows specific'); | ||
return; | ||
} | ||
|
||
const assert = require('assert'); | ||
const path = require('path'); | ||
const fs = require('fs'); | ||
|
||
const testDir = common.tmpDir; | ||
const filenameOne = 'watch.txt'; | ||
const testsubdirName = 'testsubdir'; | ||
const testsubdir = path.join(testDir, testsubdirName); | ||
const relativePathOne = path.join('testsubdir', filenameOne); | ||
const filepathOne = path.join(testsubdir, filenameOne); | ||
|
||
common.refreshTmpDir(); | ||
|
||
fs.mkdirSync(testsubdir, 0o700); | ||
|
||
const watcher = fs.watch(testDir, {recursive: true}); | ||
|
||
var watcherClosed = false; | ||
watcher.on('change', function(event, filename) { | ||
assert.ok('change' === event || 'rename' === event); | ||
|
||
// Ignore stale events generated by mkdir and other tests | ||
if (filename !== relativePathOne) | ||
return; | ||
|
||
watcher.close(); | ||
watcherClosed = true; | ||
}); | ||
|
||
fs.writeFileSync(filepathOne, 'world'); | ||
|
||
process.on('exit', function() { | ||
assert(watcherClosed, 'watcher Object was not closed'); | ||
}); |
This file was deleted.
Oops, something went wrong.