http: improve writeEarlyHints by avoiding for-of loop

haramj · targos · commit 1b25008b41e9 · 2025-10-06T16:27:11.000+02:00
PR-URL: #59958 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -330,7 +330,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {
 
   head += 'Link: ' + link + '\r\n';
 
-  for (const key of ObjectKeys(hints)) {
+  const keys = ObjectKeys(hints);
+  for (let i = 0; i < keys.length; i++) {
+    const key = keys[i];
     if (key !== 'link') {
       head += key + ': ' + hints[key] + '\r\n';
     }

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {`
`330`	`330`
`331`	`331`	`head += 'Link: ' + link + '\r\n';`
`332`	`332`
`333`		`- for (const key of ObjectKeys(hints)) {`
	`333`	`+ const keys = ObjectKeys(hints);`
	`334`	`+ for (let i = 0; i < keys.length; i++) {`
	`335`	`+ const key = keys[i];`
`334`	`336`	`if (key !== 'link') {`
`335`	`337`	`head += key + ': ' + hints[key] + '\r\n';`
`336`	`338`	`}`