Skip to content

Commit 1a2ed4a

Browse files
DanielSchuechaddaleax
authored andcommitted
http2: core.js replace var with let
const has to be used in for in loop PR-URL: #30403 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 8ee27ff commit 1a2ed4a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

lib/internal/http2/core.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ function onOrigin(origins) {
582582
if (!session.encrypted || session.destroyed)
583583
return undefined;
584584
const originSet = initOriginSet(session);
585-
for (var n = 0; n < origins.length; n++)
585+
for (let n = 0; n < origins.length; n++)
586586
originSet.add(origins[n]);
587587
session.emit('origin', origins);
588588
}
@@ -1496,7 +1496,7 @@ class ServerHttp2Session extends Http2Session {
14961496
let arr = '';
14971497
let len = 0;
14981498
const count = origins.length;
1499-
for (var i = 0; i < count; i++) {
1499+
for (let i = 0; i < count; i++) {
15001500
let origin = origins[i];
15011501
if (typeof origin === 'string') {
15021502
origin = (new URL(origin)).origin;
@@ -2128,7 +2128,7 @@ function processHeaders(oldHeaders) {
21282128
if (oldHeaders !== null && oldHeaders !== undefined) {
21292129
const hop = hasOwnProperty.bind(oldHeaders);
21302130
// This loop is here for performance reason. Do not change.
2131-
for (var key in oldHeaders) {
2131+
for (const key in oldHeaders) {
21322132
if (hop(key)) {
21332133
headers[key] = oldHeaders[key];
21342134
}

0 commit comments

Comments
 (0)