Skip to content

Commit 18f073f

Browse files
gibfahnaddaleax
authored andcommitted
build: fail linter if linting not available
PR-URL: #13658 Ref: #13645 (comment) Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 5e59c2d commit 18f073f

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -924,6 +924,7 @@ lint:
924924
@echo "Linting is not available through the source tarball."
925925
@echo "Use the git repo instead:" \
926926
"$ git clone https://github.com/nodejs/node.git"
927+
exit 1
927928

928929
lint-ci: lint
929930
endif

vcbuild.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ goto exit
485485
:no-lint
486486
echo Linting is not available through the source tarball.
487487
echo Use the git repo instead: $ git clone https://github.com/nodejs/node.git
488-
goto exit
488+
exit /b 1
489489

490490
:create-msvs-files-failed
491491
echo Failed to create vc project files.

0 commit comments

Comments
 (0)