Skip to content

Commit 18b117b

Browse files
StefanStojanovicnodejs-github-bot
authored andcommitted
deps: patch V8 to fix Windows build
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #66537 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 87c1b1c commit 18b117b

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎common.gypi‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
# Reset this number to 0 on major V8 upgrades.
4646
# Increment by one for each non-official patch applied to deps/v8.
47-
'v8_embedder_string': '-node.13',
47+
'v8_embedder_string': '-node.14',
4848

4949
##### V8 defaults for Node.js #####
5050

‎deps/v8/include/v8-internal.h‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,11 @@ struct TagRange {
526526
constexpr TagRange(Tag first, Tag last) : first(first), last(last) {
527527
#ifdef V8_ENABLE_CHECKS
528528
// This would typically be a DCHECK, but that's not available here.
529+
#if V8_HAS_BUILTIN_UNREACHABLE
529530
if (first > last) __builtin_unreachable(); // Invalid tag range.
531+
#elif defined(_MSC_VER)
532+
if (first > last) __assume(0); // Invalid tag range.
533+
#endif
530534
#endif
531535
}
532536

‎deps/v8/src/objects/backing-store.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ std::unique_ptr<BackingStore> BackingStore::TryAllocateAndPartiallyCommitMemory(
323323
// For accounting purposes, whether a GC was necessary.
324324
bool did_retry = false;
325325

326-
auto gc_retry = [&](const std::function<bool()>& fn) {
326+
auto gc_retry = [&](const auto& fn) {
327327
if (fn()) return true;
328328
// Collect garbage and retry.
329329
did_retry = true;

0 commit comments

Comments
 (0)