From 18aec6766edf215d4f6ecc175878e186ee7eca96 Mon Sep 17 00:00:00 2001 From: Brian White Date: Sat, 15 Apr 2017 00:42:25 -0400 Subject: [PATCH] url: always show password for URL instances This matches browser behavior. PR-URL: https://github.com/nodejs/node/pull/12420 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Timothy Gu Reviewed-By: Daijiro Wachi Reviewed-By: James M Snell Reviewed-By: Joyee Cheung --- lib/internal/url.js | 5 +---- test/parallel/test-whatwg-url-inspect.js | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/internal/url.js b/lib/internal/url.js index 9929c006d53e49..3fabf09beb2af5 100644 --- a/lib/internal/url.js +++ b/lib/internal/url.js @@ -215,8 +215,6 @@ class URL { throw new TypeError('Value of `this` is not a URL'); } - const ctx = this[context]; - if (typeof depth === 'number' && depth < 0) return opts.stylize('[Object]', 'special'); @@ -230,8 +228,7 @@ class URL { obj.origin = this.origin; obj.protocol = this.protocol; obj.username = this.username; - obj.password = (opts.showHidden || ctx.password === '') ? - this.password : '--------'; + obj.password = this.password; obj.host = this.host; obj.hostname = this.hostname; obj.port = this.port; diff --git a/test/parallel/test-whatwg-url-inspect.js b/test/parallel/test-whatwg-url-inspect.js index a8a59b77873f12..8db1a20e5be152 100644 --- a/test/parallel/test-whatwg-url-inspect.js +++ b/test/parallel/test-whatwg-url-inspect.js @@ -21,7 +21,7 @@ assert.strictEqual( origin: 'https://host.name:8080', protocol: 'https:', username: 'username', - password: '--------', + password: 'password', host: 'host.name:8080', hostname: 'host.name', port: '8080',