http: improve writeEarlyHints by avoiding for-of loop

haramj · haramj · commit 17e98e7fa9b5 · 2025-09-21T15:10:16.000+09:00
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -331,7 +331,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {
 
   head += 'Link: ' + link + '\r\n';
 
-  for (const key of ObjectKeys(hints)) {
+  const keys = ObjectKeys(hints);
+  for (let i = 0; i < keys.length; i++) {
+    const key = keys[i];
     if (key !== 'link') {
       head += key + ': ' + hints[key] + '\r\n';
     }

Original file line number	Diff line number	Diff line change
`@@ -331,7 +331,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {`
`331`	`331`
`332`	`332`	`head += 'Link: ' + link + '\r\n';`
`333`	`333`
`334`		`- for (const key of ObjectKeys(hints)) {`
	`334`	`+ const keys = ObjectKeys(hints);`
	`335`	`+ for (let i = 0; i < keys.length; i++) {`
	`336`	`+ const key = keys[i];`
`335`	`337`	`if (key !== 'link') {`
`336`	`338`	`head += key + ': ' + hints[key] + '\r\n';`
`337`	`339`	`}`