Skip to content

Commit 17b8381

Browse files
mscdexevanlucas
authored andcommitted
net: remove unnecessary variables
V8 is smart enough to optimize the length property checking when iterating over an array with a for loop. PR-URL: #8112 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent d9142b4 commit 17b8381

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

lib/net.js

+4-6
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,8 @@ exports.createServer = function(options, connectionListener) {
6060
// connect(path, [cb]);
6161
//
6262
exports.connect = exports.createConnection = function() {
63-
const argsLen = arguments.length;
64-
var args = new Array(argsLen);
65-
for (var i = 0; i < argsLen; i++)
63+
var args = new Array(arguments.length);
64+
for (var i = 0; i < arguments.length; i++)
6665
args[i] = arguments[i];
6766
args = normalizeConnectArgs(args);
6867
debug('createConnection', args);
@@ -885,9 +884,8 @@ Socket.prototype.connect = function(options, cb) {
885884
// Old API:
886885
// connect(port, [host], [cb])
887886
// connect(path, [cb]);
888-
const argsLen = arguments.length;
889-
var args = new Array(argsLen);
890-
for (var i = 0; i < argsLen; i++)
887+
var args = new Array(arguments.length);
888+
for (var i = 0; i < arguments.length; i++)
891889
args[i] = arguments[i];
892890
args = normalizeConnectArgs(args);
893891
return Socket.prototype.connect.apply(this, args);

0 commit comments

Comments
 (0)