src: example use of gsl::narrow to uncover a bug

Author: refack

deps/GSL/gsl/gsl_assert

@@ -125,9 +125,15 @@ namespace details
 #if defined(GSL_TERMINATE_ON_CONTRACT_VIOLATION)
 
     template <typename Exception>
-    [[noreturn]] void throw_exception(Exception&&) noexcept
+    [[noreturn]] void throw_exception(Exception&& ex) noexcept
     {
-        gsl::details::terminate();
+      static const char* const args[] = {
+        __FILE__,
+        STRINGIFY(__LINE__),
+        ex.what(),
+        PRETTY_FUNCTION_NAME
+      };
+      node::Assert(&args);
     }
 
 #else

node.gypi

@@ -29,6 +29,7 @@
     'deps/v8/include',
     'src',
   ],
+  'defines': [ 'GSL_TERMINATE_ON_CONTRACT_VIOLATION', ],
   # Putting these explicitly here so not to be dependant on common.gypi.
   'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
   'xcode_settings': {

src/node_internals.h

@@ -41,6 +41,8 @@
 #include <string>
 #include <vector>
 
+#include <gsl/gsl_util>
+
 // Custom constants used by both node_constants.cc and node_zlib.cc
 #define Z_MIN_WINDOWBITS 8
 #define Z_MAX_WINDOWBITS 15
@@ -323,7 +325,7 @@ v8::Local<v8::Value> FillStatsArray(AliasedBuffer<NativeT, V8T>* fields_ptr,
 #else
   fields[offset + 6] = 0;
 #endif
-  fields[offset + 7] = s->st_ino;
+  fields[offset + 7] = gsl::narrow<NativeT>(s->st_ino);
   fields[offset + 8] = s->st_size;
 #if defined(__POSIX__)
   fields[offset + 9] = s->st_blocks;