Skip to content

Commit 16cbd8c

Browse files
targosBethGriggs
authored andcommitted
deps: silence irrelevant V8 warnings
PR-URL: #37587 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 98150e2 commit 16cbd8c

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.5',
39+
'v8_embedder_string': '-node.6',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,7 +1653,7 @@ class V8_EXPORT Module : public Data {
16531653
*/
16541654
int GetIdentityHash() const;
16551655

1656-
using ResolveCallback V8_DEPRECATE_SOON("Use ResolveModuleCallback") =
1656+
using ResolveCallback =
16571657
MaybeLocal<Module> (*)(Local<Context> context, Local<String> specifier,
16581658
Local<Module> referrer);
16591659
using ResolveModuleCallback = MaybeLocal<Module> (*)(
@@ -7299,8 +7299,7 @@ using CallCompletedCallback = void (*)(Isolate*);
72997299
* fails (e.g. due to stack overflow), the embedder must propagate
73007300
* that exception by returning an empty MaybeLocal.
73017301
*/
7302-
using HostImportModuleDynamicallyCallback V8_DEPRECATE_SOON(
7303-
"Use HostImportModuleDynamicallyWithImportAssertionsCallback instead") =
7302+
using HostImportModuleDynamicallyCallback =
73047303
MaybeLocal<Promise> (*)(Local<Context> context,
73057304
Local<ScriptOrModule> referrer,
73067305
Local<String> specifier);

0 commit comments

Comments
 (0)