From 1634a7017e9b46dcd2510937f0dfddf958bcbd0e Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sat, 31 Dec 2016 21:51:03 -0800
Subject: [PATCH] tools: remove custom align-function-arguments rule

ESLint `indent` rule now has options that duplicate functionality in our
custom `align-function-arguments` rule. Remove
`align-function-arguments` custom rule.

PR-URL: https://github.com/nodejs/node/pull/10561
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
---
 .eslintrc                                     |  1 -
 .../eslint-rules/align-function-arguments.js  | 76 -------------------
 2 files changed, 77 deletions(-)
 delete mode 100644 tools/eslint-rules/align-function-arguments.js

diff --git a/.eslintrc b/.eslintrc
index 0aed06ca55f5c3..812637821841ce 100644
--- a/.eslintrc
+++ b/.eslintrc
@@ -120,7 +120,6 @@ rules:
   template-curly-spacing: 2
 
   # Custom rules in tools/eslint-rules
-  align-function-arguments: 2
   align-multiline-assignment: 2
   assert-fail-single-argument: 2
   assert-throws-arguments: [2, { requireTwo: false }]
diff --git a/tools/eslint-rules/align-function-arguments.js b/tools/eslint-rules/align-function-arguments.js
deleted file mode 100644
index 015552489a9d44..00000000000000
--- a/tools/eslint-rules/align-function-arguments.js
+++ /dev/null
@@ -1,76 +0,0 @@
-/**
- * @fileoverview Align arguments in multiline function calls
- * @author Rich Trott
- */
-'use strict';
-
-//------------------------------------------------------------------------------
-// Rule Definition
-//------------------------------------------------------------------------------
-
-function checkArgumentAlignment(context, node) {
-
-  function isNodeFirstInLine(node, byEndLocation) {
-    const firstToken = byEndLocation === true ? context.getLastToken(node, 1) :
-      context.getTokenBefore(node);
-    const startLine = byEndLocation === true ? node.loc.end.line :
-      node.loc.start.line;
-    const endLine = firstToken ? firstToken.loc.end.line : -1;
-
-    return startLine !== endLine;
-  }
-
-  if (node.arguments.length === 0)
-    return;
-
-  var msg = '';
-  const first = node.arguments[0];
-  var currentLine = first.loc.start.line;
-  const firstColumn = first.loc.start.column;
-
-  const ignoreTypes = [
-    'ArrowFunctionExpression',
-    'FunctionExpression',
-    'ObjectExpression',
-  ];
-
-  const args = node.arguments;
-
-  // For now, don't bother trying to validate potentially complicating things
-  // like closures. Different people will have very different ideas and it's
-  // probably best to implement configuration options.
-  if (args.some((node) => { return ignoreTypes.indexOf(node.type) !== -1; })) {
-    return;
-  }
-
-  if (!isNodeFirstInLine(node)) {
-    return;
-  }
-
-  var misaligned;
-
-  args.slice(1).forEach((argument) => {
-    if (!misaligned) {
-      if (argument.loc.start.line === currentLine + 1) {
-        if (argument.loc.start.column !== firstColumn) {
-          if (isNodeFirstInLine(argument)) {
-            msg = 'Function argument in column ' +
-                  `${argument.loc.start.column + 1}, ` +
-                  `expected in ${firstColumn + 1}`;
-            misaligned = argument;
-          }
-        }
-      }
-    }
-    currentLine = argument.loc.start.line;
-  });
-
-  if (msg)
-    context.report(misaligned, msg);
-}
-
-module.exports = function(context) {
-  return {
-    'CallExpression': (node) => checkArgumentAlignment(context, node)
-  };
-};