Skip to content

Commit 15b91fa

Browse files
targosrichardlau
authored andcommitted
deps: V8: backport 895949419186
Original commit message: Add -Wno-string-concatenation to test/cctest:cctest_sources v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation. Bug: chromium:1114873 Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69625} Refs: v8/v8@8959494 PR-URL: #39245 Refs: nodejs/build#2696 Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 8046daf commit 15b91fa

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.54',
37+
'v8_embedder_string': '-node.55',
3838

3939
##### V8 defaults for Node.js #####
4040

deps/v8/test/cctest/BUILD.gn

+7
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ v8_header_set("cctest_headers") {
6363
]
6464
}
6565

66+
config("cctest_sources_config") {
67+
if (is_clang) {
68+
cflags = [ "-Wno-string-concatenation" ]
69+
}
70+
}
71+
6672
v8_source_set("cctest_sources") {
6773
testonly = true
6874

@@ -376,6 +382,7 @@ v8_source_set("cctest_sources") {
376382
configs = [
377383
"../..:external_config",
378384
"../..:internal_config_base",
385+
":cctest_sources_config",
379386
]
380387

381388
public_deps = [

0 commit comments

Comments
 (0)