From 15b2d1331082c66adf608bb4de9987aa47a25358 Mon Sep 17 00:00:00 2001 From: pi1024e Date: Fri, 9 Aug 2019 11:15:22 -0400 Subject: [PATCH] src: organize imports in inspector_profiler.cc In the other .cc files in the project, includes are in alphabetical order, with local files first, and libraries after. However, inspector_profiler.cc has a library declared in the middle of the import order, and v8 is the second to last being imported, instead of the last. So I reordered the imports and testing showed no side effects; everything passed. PR-URL: https://github.com/nodejs/node/pull/29073 Reviewed-By: Anna Henningsen Reviewed-By: Eugene Ostroukhov Reviewed-By: Rich Trott Reviewed-By: Yongsheng Zhang --- src/inspector_profiler.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/inspector_profiler.cc b/src/inspector_profiler.cc index 122118324f57e1..e5e01dc3c9204c 100644 --- a/src/inspector_profiler.cc +++ b/src/inspector_profiler.cc @@ -1,13 +1,14 @@ #include "inspector_profiler.h" -#include #include "base_object-inl.h" #include "debug_utils.h" #include "diagnosticfilename-inl.h" #include "memory_tracker-inl.h" #include "node_file.h" #include "node_internals.h" -#include "v8-inspector.h" #include "util-inl.h" +#include "v8-inspector.h" + +#include namespace node { namespace profiler { @@ -323,7 +324,7 @@ void EndStartedProfilers(Environment* env) { std::string GetCwd(Environment* env) { char cwd[PATH_MAX_BYTES]; size_t size = PATH_MAX_BYTES; - int err = uv_cwd(cwd, &size); + const int err = uv_cwd(cwd, &size); if (err == 0) { CHECK_GT(size, 0);