lib: convert Assert class to a constructor function type

miguelmarcondesf · miguelmarcondesf · commit 1552a678d96c · 2025-06-09T20:03:36.000-03:00
diff --git a/lib/assert.js b/lib/assert.js
diff --git a/test/fixtures/errors/error_exit.snapshot b/test/fixtures/errors/error_exit.snapshot
@@ -1,13 +1,13 @@
 Exiting with code=1
 node:assert:*
-    throw new AssertionError(this.#buildAssertionErrorOptions(obj));
-    ^
+  throw new AssertionError(_buildAssertionErrorOptions(this, obj));
+  ^
 
 AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
 
 1 !== 2
 
-    at new AssertionError (node:internal*assert*assertion_error:*:*) {
+    at Object.<anonymous> (*error_exit.js:*:*) {
   generatedMessage: true,
   code: 'ERR_ASSERTION',
   actual: 1,
diff --git a/test/fixtures/errors/if-error-has-good-stack.snapshot b/test/fixtures/errors/if-error-has-good-stack.snapshot
@@ -1,12 +1,12 @@
 node:assert:*
-      throw newErr;
-      ^
+    throw newErr;
+    ^
 
 AssertionError [ERR_ASSERTION]: ifError got unwanted exception: test error
-    at new AssertionError (node:internal*assert*assertion_error:*:*)
-    at Assert.ifError (node:assert:*:*)
     at z (*if-error-has-good-stack.js:*:*)
     at y (*if-error-has-good-stack.js:*:*)
+    at x (*if-error-has-good-stack.js:*:*)
+    at Object.<anonymous> (*if-error-has-good-stack.js:*:*)
     at c (*if-error-has-good-stack.js:*:*)
     at b (*if-error-has-good-stack.js:*:*)
     at a (*if-error-has-good-stack.js:*:*)
diff --git a/test/fixtures/test-runner/output/describe_it.snapshot b/test/fixtures/test-runner/output/describe_it.snapshot
@@ -154,9 +154,6 @@ not ok 14 - async assertion fail
     *
     *
     *
-    *
-    *
-    *
   ...
 # Subtest: resolve pass
 ok 15 - resolve pass
diff --git a/test/fixtures/test-runner/output/dot_reporter.snapshot b/test/fixtures/test-runner/output/dot_reporter.snapshot
@@ -61,9 +61,6 @@ Failed tests:
       *
       *
       *
-      *
-      *
-      *
       * {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
diff --git a/test/fixtures/test-runner/output/junit_reporter.snapshot b/test/fixtures/test-runner/output/junit_reporter.snapshot
@@ -119,9 +119,6 @@ true !== false
       *
       *
       *
-      *
-      *
-      *
       * {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
diff --git a/test/fixtures/test-runner/output/output.snapshot b/test/fixtures/test-runner/output/output.snapshot
@@ -157,9 +157,6 @@ not ok 13 - async assertion fail
     *
     *
     *
-    *
-    *
-    *
   ...
 # Subtest: resolve pass
 ok 14 - resolve pass
diff --git a/test/fixtures/test-runner/output/output_cli.snapshot b/test/fixtures/test-runner/output/output_cli.snapshot
@@ -157,9 +157,6 @@ not ok 13 - async assertion fail
     *
     *
     *
-    *
-    *
-    *
   ...
 # Subtest: resolve pass
 ok 14 - resolve pass
diff --git a/test/fixtures/test-runner/output/source_mapped_locations.snapshot b/test/fixtures/test-runner/output/source_mapped_locations.snapshot
@@ -22,9 +22,6 @@ not ok 1 - fails
     *
     *
     *
-    *
-    *
-    *
   ...
 1..1
 # tests 1
diff --git a/test/fixtures/test-runner/output/spec_reporter.snapshot b/test/fixtures/test-runner/output/spec_reporter.snapshot
@@ -166,9 +166,6 @@
       *
       *
       *
-      *
-      *
-      *
       * {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
diff --git a/test/fixtures/test-runner/output/spec_reporter_cli.snapshot b/test/fixtures/test-runner/output/spec_reporter_cli.snapshot
@@ -169,9 +169,6 @@
       *
       *
       *
-      *
-      *
-      *
       * {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
diff --git a/test/message/assert_throws_stack.out b/test/message/assert_throws_stack.out
@@ -1,6 +1,6 @@
 node:assert:*
-        throw err;
-        ^
+      throw err;
+      ^
 
 AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
 + actual - expected
@@ -9,6 +9,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
 - Comparison {
 -   bar: true
 - }
+
     at Object.<anonymous> (*assert_throws_stack.js:*:*)
     at *
     at *
@@ -22,7 +23,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
   code: 'ERR_ASSERTION',
   actual: Error: foo
       at assert.throws.bar (*assert_throws_stack.js:*)
-      at #getActual (node:assert:*)
+      at getActual (node:assert:*)
       at Assert.throws (node:assert:*)
       at Object.<anonymous> (*assert_throws_stack.js:*:*)
       at *

Original file line number	Diff line number	Diff line change
`@@ -154,9 +154,6 @@ not ok 14 - async assertion fail`
`154`	`154`	`*`
`155`	`155`	`*`
`156`	`156`	`*`
`157`		`- *`
`158`		`- *`
`159`		`- *`
`160`	`157`	`...`
`161`	`158`	`# Subtest: resolve pass`
`162`	`159`	`ok 15 - resolve pass`
Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,6 @@ Failed tests:`
`61`	`61`	`*`
`62`	`62`	`*`
`63`	`63`	`*`
`64`		`- *`
`65`		`- *`
`66`		`- *`
`67`	`64`	`* {`
`68`	`65`	`generatedMessage: true,`
`69`	`66`	`code: 'ERR_ASSERTION',`
Original file line number	Diff line number	Diff line change
`@@ -119,9 +119,6 @@ true !== false`
`119`	`119`	`*`
`120`	`120`	`*`
`121`	`121`	`*`
`122`		`- *`
`123`		`- *`
`124`		`- *`
`125`	`122`	`* {`
`126`	`123`	`generatedMessage: true,`
`127`	`124`	`code: 'ERR_ASSERTION',`
Original file line number	Diff line number	Diff line change
`@@ -157,9 +157,6 @@ not ok 13 - async assertion fail`
`157`	`157`	`*`
`158`	`158`	`*`
`159`	`159`	`*`
`160`		`- *`
`161`		`- *`
`162`		`- *`
`163`	`160`	`...`
`164`	`161`	`# Subtest: resolve pass`
`165`	`162`	`ok 14 - resolve pass`
Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,6 @@ not ok 1 - fails`
`22`	`22`	`*`
`23`	`23`	`*`
`24`	`24`	`*`
`25`		`- *`
`26`		`- *`
`27`		`- *`
`28`	`25`	`...`
`29`	`26`	`1..1`
`30`	`27`	`# tests 1`
Original file line number	Diff line number	Diff line change
`@@ -166,9 +166,6 @@`
`166`	`166`	`*`
`167`	`167`	`*`
`168`	`168`	`*`
`169`		`- *`
`170`		`- *`
`171`		`- *`
`172`	`169`	`* {`
`173`	`170`	`generatedMessage: true,`
`174`	`171`	`code: 'ERR_ASSERTION',`