Skip to content

Commit 1521125

Browse files
legendecasmarco-ippolito
authored andcommitted
typings: fix ImportModuleDynamicallyCallback return type
PR-URL: #57160 Refs: https://github.com/nodejs/node/pull/56919/files#r1955336054 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f57765b commit 1521125

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

lib/internal/modules/esm/loader.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ class ModuleLoader {
280280
* @param {string} source Source code. TODO(joyeecheung): pass the raw buffer.
281281
* @param {string} isMain Whether this module is a main module.
282282
* @param {CJSModule|undefined} parent Parent module, if any.
283-
* @returns {{wrap: ModuleWrap, namespace: ModuleNamespaceObject}}
283+
* @returns {{wrap: ModuleWrap, namespace: import('internal/modules/esm/utils').ModuleNamespaceObject}}
284284
*/
285285
importSyncForRequire(mod, filename, source, isMain, parent) {
286286
const url = pathToFileURL(filename).href;

lib/internal/modules/esm/utils.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,18 @@ function getConditionsSet(conditions) {
101101
return getDefaultConditionsSet();
102102
}
103103

104+
/**
105+
* @typedef {{
106+
* [Symbol.toStringTag]: 'Module',
107+
* }} ModuleNamespaceObject
108+
*/
109+
104110
/**
105111
* @callback ImportModuleDynamicallyCallback
106112
* @param {string} specifier
107113
* @param {ModuleWrap|ContextifyScript|Function|vm.Module} callbackReferrer
108114
* @param {Record<string, string>} attributes
109-
* @returns { Promise<void> }
115+
* @returns {Promise<ModuleNamespaceObject>}
110116
*/
111117

112118
/**

0 commit comments

Comments
 (0)