Skip to content

Commit

Permalink
build: fix v8_enable_handle_zapping override
Browse files Browse the repository at this point in the history
It was previously ignored by features.gypi and therefore
enabled by default for release builds.

See https://code.google.com/p/chromium/issues/detail?id=318206

PR-URL: #2731
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
skomski authored and rvagg committed Sep 12, 2015
1 parent 4cf225d commit 1428661
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
'configurations': {
'Debug': {
'variables': {
'v8_enable_handle_zapping%': 1,
'v8_enable_handle_zapping': 1,
},
'defines': [ 'DEBUG', '_DEBUG' ],
'cflags': [ '-g', '-O0' ],
Expand All @@ -83,7 +83,7 @@
},
'Release': {
'variables': {
'v8_enable_handle_zapping%': 0,
'v8_enable_handle_zapping': 0,
},
'cflags': [ '-O3', '-ffunction-sections', '-fdata-sections' ],
'conditions': [
Expand Down

0 comments on commit 1428661

Please sign in to comment.