-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: split heap snapshot limit tests
test/parallel/test-heapsnapshot-near-heap-limit.js is timing out in CI on low-memory and slow-CPU devices. Split off the worker test to its own test file to allow the test to finish in time. Refs: #36961 PR-URL: #37189 Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
- Loading branch information
1 parent
9946c11
commit 13fe17c
Showing
2 changed files
with
36 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
'use strict'; | ||
|
||
require('../common'); | ||
const tmpdir = require('../common/tmpdir'); | ||
const assert = require('assert'); | ||
const { spawnSync } = require('child_process'); | ||
const fixtures = require('../common/fixtures'); | ||
const fs = require('fs'); | ||
const env = { | ||
...process.env, | ||
NODE_DEBUG_NATIVE: 'diagnostics' | ||
}; | ||
|
||
{ | ||
tmpdir.refresh(); | ||
const child = spawnSync(process.execPath, [ | ||
fixtures.path('workload', 'grow-worker.js') | ||
], { | ||
cwd: tmpdir.path, | ||
env: { | ||
TEST_SNAPSHOTS: 1, | ||
TEST_OLD_SPACE_SIZE: 50, | ||
...env | ||
} | ||
}); | ||
console.log(child.stdout.toString()); | ||
const stderr = child.stderr.toString(); | ||
console.log(stderr); | ||
// There should be one snapshot taken and then after the | ||
// snapshot heap limit callback is popped, the OOM callback | ||
// becomes effective. | ||
assert(stderr.includes('ERR_WORKER_OUT_OF_MEMORY')); | ||
const list = fs.readdirSync(tmpdir.path) | ||
.filter((file) => file.endsWith('.heapsnapshot')); | ||
assert.strictEqual(list.length, 1); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters