Skip to content

Commit 13cace1

Browse files
TrottMylesBorins
authored andcommitted
test: fix helper-debugger-repl.js
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
1 parent aebbc96 commit 13cace1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/debugger/helper-debugger-repl.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ function addTest(input, output) {
108108
}
109109

110110
var handshakeLines = [
111-
/listening on port \d+/,
111+
/listening on /,
112112
/connecting.* ok/
113113
];
114114

0 commit comments

Comments
 (0)