http: remove duplicate check

ronag · targos · commit 13a497912d71 · 2019-08-19T21:18:59.000+02:00
`socketOnDrain()` performs the exact same check and doesn't return anything. PR-URL: #29022 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -444,13 +444,9 @@ function connectionListenerInternal(server, socket) {
   socket._paused = false;
 }
 
-
 function updateOutgoingData(socket, state, delta) {
   state.outgoingData += delta;
-  if (socket._paused &&
-      state.outgoingData < socket.writableHighWaterMark) {
-    return socketOnDrain(socket, state);
-  }
+  socketOnDrain(socket, state);
 }
 
 function socketOnDrain(socket, state) {

Original file line number	Diff line number	Diff line change
`@@ -444,13 +444,9 @@ function connectionListenerInternal(server, socket) {`
`444`	`444`	`socket._paused = false;`
`445`	`445`	`}`
`446`	`446`
`447`		`-`
`448`	`447`	`function updateOutgoingData(socket, state, delta) {`
`449`	`448`	`state.outgoingData += delta;`
`450`		`- if (socket._paused &&`
`451`		`- state.outgoingData < socket.writableHighWaterMark) {`
`452`		`- return socketOnDrain(socket, state);`
`453`		`- }`
	`449`	`+ socketOnDrain(socket, state);`
`454`	`450`	`}`
`455`	`451`
`456`	`452`	`function socketOnDrain(socket, state) {`