src: merge fn_name in NODE_SET_PROTOTYPE_METHOD

XadillaX · MylesBorins · commit 135e1e3b0bc2 · 2017-08-15T20:57:25.000-07:00
Merge two duplicate `fn_name` into one in NODE_SET_PROTOTYPE_METHOD, it may improve a bit performance. PR-URL: #13547 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.h b/src/node.h
@@ -282,7 +282,7 @@ inline void NODE_SET_PROTOTYPE_METHOD(v8::Local<v8::FunctionTemplate> recv,
       v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), s);
   v8::Local<v8::String> fn_name = v8::String::NewFromUtf8(isolate, name);
   t->SetClassName(fn_name);
-  recv->PrototypeTemplate()->Set(v8::String::NewFromUtf8(isolate, name), t);
+  recv->PrototypeTemplate()->Set(fn_name, t);
 }
 #define NODE_SET_PROTOTYPE_METHOD node::NODE_SET_PROTOTYPE_METHOD
 

Original file line number	Diff line number	Diff line change
`@@ -282,7 +282,7 @@ inline void NODE_SET_PROTOTYPE_METHOD(v8::Local<v8::FunctionTemplate> recv,`
`282`	`282`	`v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), s);`
`283`	`283`	`v8::Local<v8::String> fn_name = v8::String::NewFromUtf8(isolate, name);`
`284`	`284`	`t->SetClassName(fn_name);`
`285`		`- recv->PrototypeTemplate()->Set(v8::String::NewFromUtf8(isolate, name), t);`
	`285`	`+ recv->PrototypeTemplate()->Set(fn_name, t);`
`286`	`286`	`}`
`287`	`287`	`#define NODE_SET_PROTOTYPE_METHOD node::NODE_SET_PROTOTYPE_METHOD`
`288`	`288`