util: skip type checks in internal getSystemErrorName

PR-URL: #18546 Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Feb 7, 2018 · 12ae334 · 12ae334
1 parent bff5d5b
commit 12ae334
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/lib/internal/util.js b/lib/internal/util.js
@@ -221,14 +221,6 @@ function getConstructorOf(obj) {
 }
 
 function getSystemErrorName(err) {
-  if (typeof err !== 'number') {
-    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err);
-  }
-  if (err >= 0 || !Number.isSafeInteger(err)) {
-    throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err',
-                                'a negative integer', err);
-  }
-
   const entry = errmap.get(err);
   return entry ? entry[0] : `Unknown system error ${err}`;
 }

diff --git a/lib/util.js b/lib/util.js
@@ -55,7 +55,7 @@ const {
 const {
   customInspectSymbol,
   deprecate,
-  getSystemErrorName,
+  getSystemErrorName: internalErrorName,
   getIdentificationOf,
   isError,
   promisify,
@@ -1139,6 +1139,17 @@ function callbackify(original) {
   return callbackified;
 }
 
+function getSystemErrorName(err) {
+  if (typeof err !== 'number') {
+    throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'err', 'number', err);
+  }
+  if (err >= 0 || !Number.isSafeInteger(err)) {
+    throw new errors.RangeError('ERR_OUT_OF_RANGE', 'err',
+                                'a negative integer', err);
+  }
+  return internalErrorName(err);
+}
+
 // Keep the `exports =` so that various functions can still be monkeypatched
 module.exports = exports = {
   _errnoException,