crypto: add ocsp_request ClientHelloParser::Reset

danbev · gibfahn · commit 1279893a4617 · 2018-01-24T02:45:29.000Z
I noticed that ocsp_request is not being reset in ClientHelloParser::Reset. I've not been able to figure out the the reason for this and wanted to bring this up just in case this was overlooked and should be reset. PR-URL: #17753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto_clienthello-inl.h b/src/node_crypto_clienthello-inl.h
@@ -40,6 +40,7 @@ inline void ClientHelloParser::Reset() {
   tls_ticket_ = nullptr;
   servername_size_ = 0;
   servername_ = nullptr;
+  ocsp_request_ = 0;
 }
 
 inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ inline void ClientHelloParser::Reset() {`
`40`	`40`	`tls_ticket_ = nullptr;`
`41`	`41`	`servername_size_ = 0;`
`42`	`42`	`servername_ = nullptr;`
	`43`	`+ ocsp_request_ = 0;`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,`