Skip to content

Commit 0e44902

Browse files
Flarnacodebytere
authored andcommitted
src: remove dead code in InternalMakeCallback
Remove unneeded condition as the first line in function already ensures that recv can't be empty. PR-URL: #31622 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 1592c47 commit 0e44902

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/api/callback.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ MaybeLocal<Value> InternalMakeCallback(Environment* env,
157157

158158
Local<Function> domain_cb = env->domain_callback();
159159
MaybeLocal<Value> ret;
160-
if (asyncContext.async_id != 0 || domain_cb.IsEmpty() || recv.IsEmpty()) {
160+
if (asyncContext.async_id != 0 || domain_cb.IsEmpty()) {
161161
ret = callback->Call(env->context(), recv, argc, argv);
162162
} else {
163163
std::vector<Local<Value>> args(1 + argc);

0 commit comments

Comments
 (0)