chore: apply private symbol to onImmediateError and address linting errors

Author: anilhelvaci

lib/_http_client.js

@@ -116,6 +116,7 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
 const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;
 const kError = Symbol('kError');
 const kImmediateError = Symbol('kImmediateError');
+const kOnImmediateError = Symbol('kOnImmediateError');
 
 const kLenientAll = HTTPParser.kLenientAll | 0;
 const kLenientNone = HTTPParser.kLenientNone | 0;
@@ -899,7 +900,7 @@ function tickOnSocket(req, socket) {
   parser.joinDuplicateHeaders = req.joinDuplicateHeaders;
 
   parser.onIncoming = parserOnIncomingClient;
-  socket.removeListener('error', socket.onImmediateError);
+  socket.removeListener('error', socket[kOnImmediateError]);
   socket.on('error', socketErrorListener);
   socket.on('data', socketOnData);
   socket.on('end', socketOnEnd);
@@ -942,10 +943,10 @@ ClientRequest.prototype.onSocket = function onSocket(socket, err) {
   const req = this;
 
   if (!err && socket) {
-    socket.onImmediateError = function onImmediateError(err) {
+    socket[kOnImmediateError] = function onImmediateError(err) {
       req[kImmediateError] = err;
     }
-    socket.on('error', socket.onImmediateError);
+    socket.on('error', socket[kOnImmediateError]);
   }
 
   process.nextTick(onSocketNT, this, socket, err);
@@ -968,7 +969,7 @@ function onSocketNT(req, socket, err) {
     }
 
     if (socket) {
-      socket.removeListener('error', socket.onImmediateError);
+      socket.removeListener('error', socket[kOnImmediateError]);
       if (!err && req.agent && !socket.destroyed) {
         socket.emit('free');
       } else {

test/parallel/test-http-client-immediate-error.js

@@ -47,18 +47,18 @@ function agentFactory(handle, count) {
   return agent;
 };
 
-const handleWithoutBind = callCount => ({
+const handleWithoutBind = (callCount) => ({
   connect: common.mustCall((req, addr, port) => {
     return UV_ENETUNREACH;
-  }, callCount), 
+  }, callCount),
   readStart() { },
   close() { },
 });
 
-const handleWithBind = callCount => ({
+const handleWithBind = (callCount) => ({
   readStart() { },
   close() { },
-  bind: common.mustCall(() => UV_EADDRINUSE, callCount), 
+  bind: common.mustCall(() => UV_EADDRINUSE, callCount),
 });
 
 const agentWithoutBind = agentFactory(handleWithoutBind(3), 3); // Because three tests will use this