Skip to content

Commit 0b5798b

Browse files
barnskiMylesBorins
authored andcommitted
src: remove outdated todo from node_crypto.cc
TODO comment from node_crypto is no longer relevant. Unification of commented code and string_bytes code would bloat the latter. Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.) Common path between those two is very limited now. PR-URL: #15104 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5522bdf commit 0b5798b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_crypto.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1607,7 +1607,6 @@ static Local<Object> X509ToObject(Environment* env, X509* cert) {
16071607
const char hex[] = "0123456789ABCDEF";
16081608
char fingerprint[EVP_MAX_MD_SIZE * 3];
16091609

1610-
// TODO(indutny): Unify it with buffer's code
16111610
for (i = 0; i < md_size; i++) {
16121611
fingerprint[3*i] = hex[(md[i] & 0xf0) >> 4];
16131612
fingerprint[(3*i)+1] = hex[(md[i] & 0x0f)];

0 commit comments

Comments
 (0)