From 0aa339e5e1a2cf759ee0789e6be0cef9f4f3e4c4 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 12 Aug 2019 10:38:30 +0200 Subject: [PATCH] test: skip test-fs-access if root Currently, if this test is run as the root user the following failure will occur: === release test-fs-access === Path: parallel/test-fs-access (node:46733) internal/test/binding: These APIs are for internal testing only. Do not use them. Can't clean tmpdir: /root/node/test/.tmp.522 Files blocking: [ 'read_only_file', 'read_write_file' ] /root/node/test/common/tmpdir.js:136 throw e; ^ Error: EACCES: permission denied, rmdir '/root/node/test/.tmp.522' at Object.rmdirSync (fs.js:693:3) at rmdirSync (/root/node/test/common/tmpdir.js:72:8) at rimrafSync (/root/node/test/common/tmpdir.js:41:7) at process.onexit (/root/node/test/common/tmpdir.js:121:5) at process.emit (events.js:214:15) { errno: -13, syscall: 'rmdir', code: 'EACCES', path: '/root/node/test/.tmp.522' } Command: ./node --expose-internals test/parallel/test-fs-access.js This commit adds a root user check and skips this test if running as the user root. PR-URL: https://github.com/nodejs/node/pull/29092 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig Reviewed-By: Yongsheng Zhang Reviewed-By: Jiawen Geng --- test/parallel/test-fs-access.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/parallel/test-fs-access.js b/test/parallel/test-fs-access.js index d0f730f25e12dd..a4057dcb8352b6 100644 --- a/test/parallel/test-fs-access.js +++ b/test/parallel/test-fs-access.js @@ -5,6 +5,9 @@ // and the errors thrown from these APIs include the desired properties const common = require('../common'); +if (!common.isWindows && process.getuid() === 0) + common.skip('as this test should not be run as `root`'); + const assert = require('assert'); const fs = require('fs'); const path = require('path');