crypto: add ocsp_request ClientHelloParser::Reset

danbev · MylesBorins · commit 081eea204bb5 · 2018-02-10T21:03:55.000-05:00
I noticed that ocsp_request is not being reset in ClientHelloParser::Reset. I've not been able to figure out the the reason for this and wanted to bring this up just in case this was overlooked and should be reset. PR-URL: #17753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto_clienthello-inl.h b/src/node_crypto_clienthello-inl.h
@@ -19,6 +19,7 @@ inline void ClientHelloParser::Reset() {
   tls_ticket_ = nullptr;
   servername_size_ = 0;
   servername_ = nullptr;
+  ocsp_request_ = 0;
 }
 
 inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ inline void ClientHelloParser::Reset() {`
`19`	`19`	`tls_ticket_ = nullptr;`
`20`	`20`	`servername_size_ = 0;`
`21`	`21`	`servername_ = nullptr;`
	`22`	`+ ocsp_request_ = 0;`
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb,`