fixup! lib: avoid mutating Error.stackTraceLimit when Error is frozen

Author: aduh95

test/parallel/test-errors-systemerror-stackTraceLimit-custom-setter.js

@@ -0,0 +1,30 @@
+// Flags: --expose-internals
+'use strict';
+require('../common');
+const assert = require('assert');
+const { E, SystemError, codes } = require('internal/errors');
+
+let stackTraceLimit;
+Reflect.defineProperty(Error, 'stackTraceLimit', {
+  get() { return stackTraceLimit; },
+  set(value) { stackTraceLimit = value; },
+});
+
+E('ERR_TEST', 'custom message', SystemError);
+const { ERR_TEST } = codes;
+
+const ctx = {
+  code: 'ETEST',
+  message: 'code message',
+  syscall: 'syscall_test',
+  path: '/str',
+  dest: '/str2'
+};
+assert.throws(
+  () => { throw new ERR_TEST(ctx); },
+  {
+    code: 'ERR_TEST',
+    name: 'SystemError',
+    info: ctx,
+  }
+);

test/parallel/test-errors-systemerror-stackTraceLimit-deleted-and-Error-sealed.js

@@ -0,0 +1,27 @@
+// Flags: --expose-internals
+'use strict';
+require('../common');
+const assert = require('assert');
+const { E, SystemError, codes } = require('internal/errors');
+
+delete Error.stackTraceLimit;
+Object.seal(Error);
+
+E('ERR_TEST', 'custom message', SystemError);
+const { ERR_TEST } = codes;
+
+const ctx = {
+  code: 'ETEST',
+  message: 'code message',
+  syscall: 'syscall_test',
+  path: '/str',
+  dest: '/str2'
+};
+assert.throws(
+  () => { throw new ERR_TEST(ctx); },
+  {
+    code: 'ERR_TEST',
+    name: 'SystemError',
+    info: ctx,
+  }
+);

test/parallel/test-errors-systemerror-stackTraceLimit-deleted.js

@@ -0,0 +1,26 @@
+// Flags: --expose-internals
+'use strict';
+require('../common');
+const assert = require('assert');
+const { E, SystemError, codes } = require('internal/errors');
+
+delete Error.stackTraceLimit;
+
+E('ERR_TEST', 'custom message', SystemError);
+const { ERR_TEST } = codes;
+
+const ctx = {
+  code: 'ETEST',
+  message: 'code message',
+  syscall: 'syscall_test',
+  path: '/str',
+  dest: '/str2'
+};
+assert.throws(
+  () => { throw new ERR_TEST(ctx); },
+  {
+    code: 'ERR_TEST',
+    name: 'SystemError',
+    info: ctx,
+  }
+);

test/parallel/test-errors-systemerror-stackTraceLimit-has-only-a-getter.js

@@ -0,0 +1,26 @@
+// Flags: --expose-internals
+'use strict';
+require('../common');
+const assert = require('assert');
+const { E, SystemError, codes } = require('internal/errors');
+
+Reflect.defineProperty(Error, 'stackTraceLimit', { get() { return 0; } });
+
+E('ERR_TEST', 'custom message', SystemError);
+const { ERR_TEST } = codes;
+
+const ctx = {
+  code: 'ETEST',
+  message: 'code message',
+  syscall: 'syscall_test',
+  path: '/str',
+  dest: '/str2'
+};
+assert.throws(
+  () => { throw new ERR_TEST(ctx); },
+  {
+    code: 'ERR_TEST',
+    name: 'SystemError',
+    info: ctx,
+  }
+);

test/parallel/test-errors-systemerror-stackTraceLimit-not-writable.js

@@ -0,0 +1,29 @@
+// Flags: --expose-internals
+'use strict';
+require('../common');
+const assert = require('assert');
+const { E, SystemError, codes } = require('internal/errors');
+
+Reflect.defineProperty(Error, 'stackTraceLimit', {
+  writable: false,
+  value: Error.stackTraceLimit,
+});
+
+E('ERR_TEST', 'custom message', SystemError);
+const { ERR_TEST } = codes;
+
+const ctx = {
+  code: 'ETEST',
+  message: 'code message',
+  syscall: 'syscall_test',
+  path: '/str',
+  dest: '/str2'
+};
+assert.throws(
+  () => { throw new ERR_TEST(ctx); },
+  {
+    code: 'ERR_TEST',
+    name: 'SystemError',
+    info: ctx,
+  }
+);