lib,src: remove --no-experimental-websocket CLI flag

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65284
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Author: aduh95

doc/api/cli.md

@@ -2147,14 +2147,6 @@ changes:
 
 Disable the experimental [`node:sqlite`][] module.
 
-### `--no-experimental-websocket`
-
-<!-- YAML
-added: v22.0.0
--->
-
-Disable exposition of {WebSocket} on the global scope.
-
 ### `--no-experimental-webstorage`
 
 <!-- YAML
@@ -3911,6 +3903,7 @@ one is included in the list below.
 * `--experimental-vm-modules`
 * `--experimental-wasi-unstable-preview1`
 * `--experimental-web-worker`
+* `--experimental-websocket`
 * `--force-context-aware`
 * `--force-fips`
 * `--force-node-api-uncaught-exceptions-policy`
@@ -3941,7 +3934,6 @@ one is included in the list below.
 * `--no-experimental-global-navigator`
 * `--no-experimental-sqlite`
 * `--no-experimental-strip-types`
-* `--no-experimental-websocket`
 * `--no-experimental-webstorage`
 * `--no-extra-info-on-fatal-exception`
 * `--no-force-async-hooks-checks`

doc/api/globals.md

@@ -334,10 +334,13 @@ added: v0.0.1
 
 <!-- YAML
 added: v23.0.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/65284
+    description: No longer disableable with the `--no-experimental-websocket` CLI flag.
 -->
 
-A browser-compatible implementation of {CloseEvent}. Disable this API
-with the [`--no-experimental-websocket`][] CLI flag.
+A browser-compatible implementation of {CloseEvent}.
 
 ## Class: `CompressionStream`
 
@@ -1299,6 +1302,9 @@ added:
   - v21.0.0
   - v20.10.0
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/65284
+    description: No longer disableable with the `--no-experimental-websocket` CLI flag.
   - version: v22.4.0
     pr-url: https://github.com/nodejs/node/pull/53352
     description: No longer experimental.
@@ -1307,8 +1313,7 @@ changes:
     description: No longer behind `--experimental-websocket` CLI flag.
 -->
 
-A browser-compatible implementation of {WebSocket}. Disable this API
-with the [`--no-experimental-websocket`][] CLI flag.
+A browser-compatible implementation of {WebSocket}.
 
 ## Class: `Worker`
 
@@ -1462,7 +1467,6 @@ A browser-compatible implementation of [`WritableStreamDefaultWriter`][].
 [`--experimental-web-worker`]: cli.md#--experimental-web-worker
 [`--localstorage-file`]: cli.md#--localstorage-filefile
 [`--no-experimental-global-navigator`]: cli.md#--no-experimental-global-navigator
-[`--no-experimental-websocket`]: cli.md#--no-experimental-websocket
 [`--no-experimental-webstorage`]: cli.md#--no-experimental-webstorage
 [`ByteLengthQueuingStrategy`]: webstreams.md#class-bytelengthqueuingstrategy
 [`CompressionStream`]: webstreams.md#class-compressionstream

doc/node.1

@@ -1110,9 +1110,6 @@ Legacy alias for \fB--no-require-module\fR.
 .It Fl -no-experimental-sqlite
 Disable the experimental \fBnode:sqlite\fR module.
 .
-.It Fl -no-experimental-websocket
-Disable exposition of \fB<WebSocket>\fR on the global scope.
-.
 .It Fl -no-experimental-webstorage
 Disable \fBWeb Storage\fR support.
 .
@@ -2032,6 +2029,8 @@ one is included in the list below.
 .It
 \fB--experimental-web-worker\fR
 .It
+\fB--experimental-websocket\fR
+.It
 \fB--force-context-aware\fR
 .It
 \fB--force-fips\fR
@@ -2092,8 +2091,6 @@ one is included in the list below.
 .It
 \fB--no-experimental-strip-types\fR
 .It
-\fB--no-experimental-websocket\fR
-.It
 \fB--no-experimental-webstorage\fR
 .It
 \fB--no-extra-info-on-fatal-exception\fR

lib/internal/process/pre_execution.js

@@ -122,7 +122,6 @@ function prepareExecution(options) {
   setupQuic();
   setupWebStorage();
   removeWebWorkersIfDisabled();
-  setupWebsocket();
   setupEventsource();
   setupCodeCoverage();
   setupDebugEnv();
@@ -358,14 +357,6 @@ function setupWarningHandler() {
   }
 }
 
-// https://websockets.spec.whatwg.org/
-function setupWebsocket() {
-  if (getOptionValue('--no-experimental-websocket')) {
-    delete globalThis.WebSocket;
-    delete globalThis.CloseEvent;
-  }
-}
-
 // https://html.spec.whatwg.org/multipage/workers.html
 function removeWebWorkersIfDisabled() {
   if (!getOptionValue('--experimental-web-worker')) {

src/node_options.cc

@@ -600,11 +600,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             BOOL_FIELD(experimental_web_worker),
             kAllowedInEnvvar,
             false);
-  AddOption("--experimental-websocket",
-            "experimental WebSocket API",
-            BOOL_FIELD(experimental_websocket),
-            kAllowedInEnvvar,
-            true);
+  AddOption("--experimental-websocket", "", NoOp{}, kAllowedInEnvvar);
   AddOption("--experimental-global-customevent", "", NoOp{}, kAllowedInEnvvar);
   AddOption("--experimental-sqlite",
             "experimental node:sqlite module",