Skip to content

Commit 03eec13

Browse files
committed
build: re-run configure on node_version.h change
Fixes: #29509 PR-URL: #29510 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 484c24f commit 03eec13

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,9 @@ out/Makefile: config.gypi common.gypi node.gyp \
146146
tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp
147147
$(PYTHON) tools/gyp_node.py -f make
148148

149-
config.gypi: configure configure.py
149+
# node_version.h is listed because the N-API version is taken from there
150+
# and included in config.gypi
151+
config.gypi: configure configure.py src/node_version.h
150152
@if [ -x config.status ]; then \
151153
./config.status; \
152154
else \

0 commit comments

Comments
 (0)